Skip to content

build: include rust-toolchain.toml#5376

Merged
0x009922 merged 1 commit intohyperledger-iroha:mainfrom
0x009922:include-rust-toolchain-toml
Mar 25, 2025
Merged

build: include rust-toolchain.toml#5376
0x009922 merged 1 commit intohyperledger-iroha:mainfrom
0x009922:include-rust-toolchain-toml

Conversation

@0x009922
Copy link
Copy Markdown
Contributor

Close #5051

Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
@0x009922
Copy link
Copy Markdown
Contributor Author

@BAStos525 could you please tell if this addition causes problems for Docker builds?

@BAStos525
Copy link
Copy Markdown
Contributor

@BAStos525 could you please tell if this addition causes problems for Docker builds?

Do we need to import this toolchain file into docker image?
Btw, this docker image PR build job was succeed

@s8sato
Copy link
Copy Markdown
Contributor

s8sato commented Mar 21, 2025

We might need to focus more on Docker builds on M1 macOS rather than CI: #2690 #3451 #4351

@0x009922
Copy link
Copy Markdown
Contributor Author

Do we need to import this toolchain file into docker image?

No, it isn't necessary while the right toolchain is specified in Dockerfile explicitly.

@0x009922 0x009922 merged commit ec3c07c into hyperledger-iroha:main Mar 25, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce rust-toolchain.toml

4 participants