Skip to content

fix(core): Add checks for role presence before granting it#5300

Merged
aoyako merged 9 commits intohyperledger-iroha:mainfrom
aoyako:validate_role_id
Feb 23, 2025
Merged

fix(core): Add checks for role presence before granting it#5300
aoyako merged 9 commits intohyperledger-iroha:mainfrom
aoyako:validate_role_id

Conversation

@aoyako
Copy link
Copy Markdown
Contributor

@aoyako aoyako commented Jan 31, 2025 •
edited
Loading

Resolves #5246.

Verify that the role is present in the world before assigning it.

Example that should pass:

{
    "Register": {
        "Role": {
            "id": "good_role",
            "permissions": [
                {
                    "name": "CanSetParameters",
                    "payload": null
                }
            ],
            "grant_to": "ed0120E9F632D3034BAB6BB26D92AC8FD93EF878D9C5E69E01B61B4C47101884EE2F99@garden_of_live_flowers"
        }
    }
},
{
    "Grant": {
        "Role": {
            "object": "good_role",
            "destination": "ed0120CE7FA46C9DCE7EA4B125E2E36BDB63EA33073E7590AC92816AE1E861B7048B03@wonderland"
        }
    }
}

Example that should fail:

{
    "Grant": {
        "Role": {
            "object": "bad_role",
            "destination": "ed0120CE7FA46C9DCE7EA4B125E2E36BDB63EA33073E7590AC92816AE1E861B7048B03@wonderland"
        }
    }
}

aoyako added 2 commits January 31, 2025 19:52
@aoyako
fix: check role id in transaction
7c33c25 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
chore: fix broken docs link
2e05e1b 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
s8sato
s8sato previously approved these changes Feb 3, 2025
View reviewed changes
Comment thread crates/iroha_smart_contract_utils/src/lib.rs Outdated
@aoyako @s8sato
Update crates/iroha_smart_contract_utils/src/lib.rs
a523504 
Co-authored-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com>
Signed-off-by: Mykhailo Lohachov <lohachov@soramitsu.co.jp>
s8sato
s8sato previously approved these changes Feb 3, 2025
View reviewed changes
@s8sato s8sato self-assigned this Feb 3, 2025
@aoyako
add: cover test for role transfer
29e9f2c 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
fix: fmt
b3093d0 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
Merge branch 'main' into validate_role_id
0958bff
s8sato
s8sato previously approved these changes Feb 12, 2025
View reviewed changes
@aoyako
fix: adjust fuel in tests
fee7e9e 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
0x009922
0x009922 approved these changes Feb 21, 2025
View reviewed changes
Comment thread crates/iroha/tests/roles.rs
@aoyako aoyako self-assigned this Feb 22, 2025
@aoyako aoyako merged commit b5396e9 into hyperledger-iroha:main Feb 23, 2025
@aoyako aoyako mentioned this pull request Feb 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x009922 0x009922 0x009922 approved these changes

@s8sato s8sato s8sato approved these changes

@mversic mversic Awaiting requested review from mversic mversic is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@s8sato s8sato

@aoyako aoyako

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Granting unexisting role

3 participants

@aoyako @0x009922 @s8sato