refactor: Umbrella Iroha CLI#5282
Merged
aoyako merged 15 commits intohyperledger-iroha:mainfrom Feb 22, 2025
Merged
Conversation
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
s8sato
previously approved these changes
Jan 23, 2025
00143f6 to
2459919
Compare
2459919 to
b2249ac
Compare
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
b2249ac to
ffaa729
Compare
s8sato
reviewed
Feb 18, 2025
Co-authored-by: Shunkichi Sato <49983831+s8sato@users.noreply.github.com> Signed-off-by: Mykhailo Lohachov <lohachov@soramitsu.co.jp>
s8sato
approved these changes
Feb 18, 2025
0x009922
approved these changes
Feb 21, 2025
Contributor
0x009922
left a comment
There was a problem hiding this comment.
Certainly seems like a change for the best!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4969
This PR begins the unification of cli tools into the iroha/kagami tools.
#4969 (comment)
#4969 (comment)
#4969 (comment)
Changes introduced extend the default scope of kagami by adding:
codec(types, json-to-scale, scale-to-json, scale-to-rust)wasm(from wasm_builder)kura(from kura_inspector)swarm(from iroha_swarm)Documentation in the readme is updated as well. I believe the documentation update on the website will be updated afterward.
The
swarmandwasm_builderlibraries are left intact in case they are later reused in the code.