Skip to content

feat: Add listen timeouts to iroha cli#5241

Merged
aoyako merged 20 commits intohyperledger-iroha:mainfrom
aoyako:listen_timeouts
Nov 21, 2024
Merged

feat: Add listen timeouts to iroha cli#5241
aoyako merged 20 commits intohyperledger-iroha:mainfrom
aoyako:listen_timeouts

Conversation

@aoyako
Copy link
Copy Markdown
Contributor

@aoyako aoyako commented Nov 18, 2024

Resolves #2941

Now iroha-cli can take argument --timeout=<seconds> for listen commands. The client will exit when no message is received during this interval.

Review notes (optional)

  • For complex PRs, try to provide some information on how to approach the review more effectively.
  • For example, is there a natural order in which the affected files should be reviewed?

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@aoyako
feat: add timeouts to client cli
cb3a5b2 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
chore: remove unused macro
5d49a04 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako aoyako changed the title Add listen timeouts to iroha cli feat: Add listen timeouts to iroha cli Nov 18, 2024
@s8sato s8sato self-assigned this Nov 18, 2024
@aoyako
Merge branch 'main' into listen_timeouts
277c30e
@aoyako
test: add tests for cli
f40377c 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
mversic
mversic reviewed Nov 18, 2024
View reviewed changes
Comment thread crates/iroha_cli/Cargo.toml Outdated
s8sato
s8sato reviewed Nov 18, 2024
View reviewed changes
Comment thread crates/iroha_cli/src/main.rs Outdated
Comment thread crates/iroha_cli/src/main.rs Outdated
Comment thread crates/iroha_cli/src/main.rs
DCNick3
DCNick3 reviewed Nov 18, 2024
View reviewed changes
Comment thread crates/iroha_cli/src/main.rs Outdated
@aoyako
fix: test codecover
baa3b17 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
fix: remove unused tests
ae89ae8 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
chore: newlines
805c0fa 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
chore: make args global
7738409 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@github-actions github-actions bot added the config-changes Changes in configuration and start up of the Iroha label Nov 18, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 18, 2024

@BAStos525

@aoyako
chore: update docker-compose.single.yml
bc082ec 
Signed-off-by: Mykhailo Lohachov <lohachov@soramitsu.co.jp>
@aoyako
fix: use float for duration
3eb704f 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
Merge branch 'main' into listen_timeouts
1f0f7c4
@aoyako
Merge branch 'main' into listen_timeouts
ac02c69
@aoyako
fix: use milis in events streaming
8fd4f1f 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
chore: fix compose
7391d98 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
fix: use humantime
10f92a8 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
test: add integration test
4b455c1 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
Merge branch 'main' into listen_timeouts
f49d375
@aoyako
chore: fmt
a000b8d 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
chore: fmt
b1a6295 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
s8sato
s8sato previously approved these changes Nov 20, 2024
View reviewed changes
Comment thread crates/iroha_cli/src/main.rs
Comment thread pytests/iroha_cli_tests/test/events/__init__.py
DCNick3
DCNick3 reviewed Nov 21, 2024
View reviewed changes
Comment thread pytests/iroha_cli_tests/test/events/__init__.py
Comment thread pytests/iroha_cli_tests/pyproject.toml Outdated
@aoyako
chore: update python test dependencies
4e3f995 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako aoyako enabled auto-merge (squash) November 21, 2024 10:42
@aoyako aoyako merged commit 8836304 into hyperledger-iroha:main Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mversic mversic mversic left review comments

@DCNick3 DCNick3 DCNick3 approved these changes

@s8sato s8sato s8sato approved these changes

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

Assignees

@DCNick3 DCNick3

@s8sato s8sato

@aoyako aoyako

Labels

config-changes Changes in configuration and start up of the Iroha

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[suggestion] Events listening timeout in Client CLI

5 participants

@aoyako @DCNick3 @0x009922 @mversic @s8sato