Skip to content

feat: Add --release flag to wasm_builder#5209

Merged
aoyako merged 69 commits intohyperledger-iroha:mainfrom
aoyako:wasm_builder_flags
Jan 31, 2025
Merged

feat: Add --release flag to wasm_builder#5209
aoyako merged 69 commits intohyperledger-iroha:mainfrom
aoyako:wasm_builder_flags

Conversation

@aoyako
Copy link
Copy Markdown
Contributor

@aoyako aoyako commented Oct 30, 2024

Context

Resolves #5202

Problem

The current version of iroha_wasm_builder has a --release flag set by default for its output.
The input --optimize flag can be set that will apply -O -Os.
Still, it cannot produce a build in debug mode.

Solution

Changes in iroha_wasm_builder

This PR introduces a single flag --release that:

  • When set, apply --release -O -Os to the build.
  • When not set, produce a debug build.

Changes in build_wasm.sh

Now, build_wasm.sh produces a debug build by default. Flag --release can be added to build in optimized mode.

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

aoyako added 2 commits October 30, 2024 23:08
@aoyako
feat: add option to build wasm with optimizations
a7e2a5f 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
fix: rename optimize to release in build_wasm.sh
acddbdc 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako aoyako changed the title Feat: Add --release flag to wasm_builder feat: Add --release flag to wasm_builder Oct 30, 2024
aoyako added 2 commits October 30, 2024 23:30
@aoyako
Merge branch 'main' into wasm_builder_flags
1fdecf7
@aoyako
chore: cargo fmt
5384b00 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako aoyako marked this pull request as draft October 30, 2024 15:46
aoyako added 2 commits October 31, 2024 01:19
@aoyako
fix: use correct binary directory for debug
986a835 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
chore: cargo fmt
7a5b957 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako aoyako marked this pull request as ready for review October 30, 2024 16:28
s8sato
s8sato reviewed Oct 30, 2024
View reviewed changes
Comment thread scripts/build_wasm.sh
Comment thread crates/iroha_wasm_builder/src/lib.rs Outdated
@s8sato s8sato assigned s8sato and aoyako and unassigned s8sato Oct 30, 2024
@aoyako
fix: use profile env from compose files
3e6eb1f 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
s8sato
s8sato reviewed Oct 31, 2024
View reviewed changes
Comment thread scripts/build_wasm.sh Outdated
@aoyako aoyako marked this pull request as draft October 31, 2024 08:42
aoyako added 4 commits November 7, 2024 19:43
@aoyako
fix: stack overflow caused by compact
5c6e4a8 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
Merge branch 'main' into wasm_builder_flags
ade7dc3
@aoyako
feat: add help message to build wasm readme
441d939 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
feat: add help message to build wasm readme
fc8f661 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako aoyako marked this pull request as ready for review November 7, 2024 10:53
mversic
mversic reviewed Dec 1, 2024
View reviewed changes
Comment thread crates/iroha_wasm_builder/src/lib.rs Outdated
@aoyako
fix: optional output
7980eae 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
aoyako added 3 commits December 2, 2024 20:14
@aoyako
Merge branch 'main' into wasm_builder_flags
b7b783c
@aoyako
fix: remove spinner from lib
da9f63e 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
fix: fmt
40416e0 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
s8sato
s8sato reviewed Dec 4, 2024
View reviewed changes
Comment thread crates/iroha_wasm_builder/src/main.rs
s8sato
s8sato reviewed Dec 5, 2024
View reviewed changes
Comment thread crates/iroha_wasm_builder/src/lib.rs Outdated
0x009922
0x009922 reviewed Dec 6, 2024
View reviewed changes
Comment thread .config/nextest.toml Outdated
Comment thread crates/iroha_core/src/sumeragi/main_loop.rs Outdated
Comment thread crates/iroha_test_network/src/lib.rs Outdated
Comment thread crates/iroha_test_network/src/lib.rs Outdated
Comment thread crates/iroha_wasm_builder/src/lib.rs Outdated
Comment thread crates/iroha_wasm_builder/src/main.rs Outdated
Comment thread crates/iroha_wasm_builder/src/main.rs Outdated
aoyako added 4 commits December 7, 2024 20:39
@aoyako
fix: update porfile parsing
0cba0b8 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
fix: use profiles for custom executors
a10f446 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako
Merge branch 'main' into wasm_builder_flags
07cb9fe
@aoyako
chore: fmt
2c14c7f 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
0x009922
0x009922 reviewed Dec 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can approve after last minor chores.

Comment thread crates/iroha_test_network/src/lib.rs Outdated
Comment thread crates/iroha_test_samples/src/lib.rs Outdated
Comment thread crates/iroha_core/src/sumeragi/main_loop.rs Outdated
@aoyako
Merge branch 'main' into wasm_builder_flags
b462b2f
@aoyako
perf: read build config
1e759d2 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
0x009922
0x009922 previously approved these changes Dec 13, 2024
View reviewed changes
s8sato
s8sato previously approved these changes Dec 13, 2024
View reviewed changes
@aoyako
fix: parse lowercase
111824b 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako aoyako dismissed stale reviews from s8sato and 0x009922 via 111824b December 13, 2024 07:58
@mversic mversic requested review from 0x009922 and mversic January 30, 2025 08:20
@aoyako aoyako merged commit 4e0067d into hyperledger-iroha:main Jan 31, 2025
@aoyako aoyako mentioned this pull request Feb 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BAStos525 BAStos525 BAStos525 left review comments

@0x009922 0x009922 0x009922 approved these changes

@s8sato s8sato s8sato approved these changes

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@mversic mversic Awaiting requested review from mversic mversic is a code owner

Assignees

@0x009922 0x009922

@mversic mversic

@s8sato s8sato

@aoyako aoyako

Labels

config-changes Changes in configuration and start up of the Iroha

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add --release flag to iroha_wasm_builder

5 participants

@aoyako @0x009922 @mversic @s8sato @BAStos525