Skip to content

refactor: remove module-based api from client#5184

Merged
mversic merged 3 commits intohyperledger-iroha:mainfrom
aoyako:revise_client_query_api
Oct 24, 2024
Merged

refactor: remove module-based api from client#5184
mversic merged 3 commits intohyperledger-iroha:mainfrom
aoyako:revise_client_query_api

Conversation

@aoyako
Copy link
Copy Markdown
Contributor

@aoyako aoyako commented Oct 23, 2024

Resolves #4892
Context: #4833 (comment)

Solution

This PR removes helper query functions (such as asset::all_definitions()) in the client. Instead, an API similar to the one in smartcontracts is preferred (FindAllAssetDefinitions::new()).

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Oct 23, 2024
@aoyako aoyako changed the title refactor: revise http client query api refactor: remove module-based api from client Oct 23, 2024
@aoyako aoyako marked this pull request as draft October 23, 2024 09:09
@aoyako aoyako force-pushed the revise_client_query_api branch 3 times, most recently from eebcbaf to 7629d73 Compare October 23, 2024 09:19
@aoyako aoyako marked this pull request as ready for review October 23, 2024 09:21
nxsaken
nxsaken reviewed Oct 23, 2024
View reviewed changes
Comment thread crates/iroha_data_model/src/query/mod.rs Outdated
nxsaken
nxsaken previously approved these changes Oct 23, 2024
View reviewed changes
0x009922
0x009922 approved these changes Oct 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@0x009922 0x009922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aoyako added 3 commits October 24, 2024 08:54
@aoyako @mversic
refactor: remove module-based api from client
3bf2ba8 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako @mversic
refactor: replace FindAllAssetDefinitions with FindAssetsDefinitions
facee96 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@aoyako @mversic
chore: change rustc version to nightly
323d901 
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
@mversic mversic force-pushed the revise_client_query_api branch from 2367c41 to 323d901 Compare October 24, 2024 06:54
@mversic mversic enabled auto-merge (squash) October 24, 2024 06:55
@mversic mversic merged commit 36ebb23 into hyperledger-iroha:main Oct 24, 2024
@aoyako aoyako deleted the revise_client_query_api branch October 24, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mversic mversic mversic left review comments

@0x009922 0x009922 0x009922 approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

+1 more reviewer

@nxsaken nxsaken nxsaken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api-changes Changes in the API for client libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

revise query API on client

4 participants

@aoyako @nxsaken @0x009922 @mversic