Skip to content

chore: remove unused dependencies#5173

Merged
mversic merged 1 commit intohyperledger-iroha:mainfrom
mversic:remove_unused_deps
Oct 21, 2024
Merged

chore: remove unused dependencies#5173
mversic merged 1 commit intohyperledger-iroha:mainfrom
mversic:remove_unused_deps

Conversation

@mversic
Copy link
Copy Markdown
Contributor

@mversic mversic commented Oct 20, 2024

Context

  • Describe the objective or issue this PR addresses, as well as the impact of the change.
  • Try to keep the description accessible to newcomers.
  • If you're resolving a specific issue, add "Fixes #issue_number" or "Closes #issue_number".

Solution

  • Describe the approach taken to achieve the objective / resolve the issue.

Migration Guide (optional)

  • If this PR contains a breaking change relative to the main branch, provide an instruction on how affected parties might need to adapt to the change.

Review notes (optional)

  • For complex PRs, try to provide some information on how to approach the review more effectively.
  • For example, is there a natural order in which the affected files should be reviewed?

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@mversic mversic enabled auto-merge (squash) October 20, 2024 21:11
@mversic
chore: remove unused dependencies
e0f65a3 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic force-pushed the remove_unused_deps branch from 726574e to e0f65a3 Compare October 20, 2024 21:51
@mversic mversic merged commit 24bfbe4 into hyperledger-iroha:main Oct 21, 2024
@mversic mversic deleted the remove_unused_deps branch October 21, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x009922 0x009922 0x009922 approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

+1 more reviewer

@nxsaken nxsaken nxsaken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mversic @nxsaken @0x009922