fix(iroha_config): broken trusted peers check#5121
Merged
0x009922 merged 1 commit intohyperledger-iroha:mainfrom Oct 8, 2024
Merged
fix(iroha_config): broken trusted peers check#51210x009922 merged 1 commit intohyperledger-iroha:mainfrom
0x009922 merged 1 commit intohyperledger-iroha:mainfrom
Conversation
8 tasks
s8sato
reviewed
Oct 7, 2024
s8sato
approved these changes
Oct 7, 2024
DCNick3
approved these changes
Oct 7, 2024
Contributor
|
there seem to be a test failing |
Contributor
Author
Yup, flaky unrelated test ( |
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
41c155d to
e43db16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Split from #5087
When there was one trusted peer, it decided that there are no.
Solution
Fix the check
Migration Guide (optional)
None
Review notes (optional)
None
Checklist
CONTRIBUTING.md.