Skip to content

perf: Directly provide payload to WASM entrypoints#5113

Merged
dima74 merged 1 commit intohyperledger-iroha:mainfrom
dima74:diralik/simplify-executor-entrypoint
Oct 2, 2024
Merged

perf: Directly provide payload to WASM entrypoints#5113
dima74 merged 1 commit intohyperledger-iroha:mainfrom
dima74:diralik/simplify-executor-entrypoint

Conversation

@dima74
Copy link
Copy Markdown
Contributor

@dima74 dima74 commented Oct 1, 2024

Context

Fixes #5074

Solution

From the issue:

when wasm is executed it's entrypoint function is always without arguments and does a callback to get_xxx_context to initialize. We should remove that (as it saves us one call to host) and directly provide an encoded argument when calling the entrypoint function.

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@mversic mversic self-assigned this Oct 2, 2024
@dima74 dima74 force-pushed the diralik/simplify-executor-entrypoint branch from d474b41 to 1e8b4f7 Compare October 2, 2024 08:01
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
@dima74 dima74 force-pushed the diralik/simplify-executor-entrypoint branch from 1e8b4f7 to bc47672 Compare October 2, 2024 08:10
@Erigara Erigara self-assigned this Oct 2, 2024
@dima74 dima74 merged commit 4ed4632 into hyperledger-iroha:main Oct 2, 2024
@dima74 dima74 deleted the diralik/simplify-executor-entrypoint branch October 2, 2024 09:15
@dima74 dima74 mentioned this pull request Oct 2, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove get_xxx_context functions from wasm

4 participants