fix(torii): close ws properly in blocks/events stream#5101
Merged
mversic merged 1 commit intohyperledger-iroha:mainfrom Oct 10, 2024
Merged
fix(torii): close ws properly in blocks/events stream#5101mversic merged 1 commit intohyperledger-iroha:mainfrom
mversic merged 1 commit intohyperledger-iroha:mainfrom
Conversation
dima74
previously approved these changes
Sep 26, 2024
DCNick3
reviewed
Oct 7, 2024
Contributor
DCNick3
left a comment
There was a problem hiding this comment.
This seems like quite a good improvement over what we had before
DCNick3
approved these changes
Oct 8, 2024
dima74
approved these changes
Oct 8, 2024
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Closes #5004.
Problem was that iroha tried to unconditionally closed websocket by writing into it.
During another problems were discovered as well:
Streamimplementation was incorrect by not registering itself on receiving non binary messageSolution
Fix mentioned problems + refactoring.