Skip to content

fix(ffi): Add implementation of Niche for Option<Box<R>>#5094

Merged
mversic merged 1 commit intohyperledger-iroha:mainfrom
mversic:fix_ffi_option_box
Sep 23, 2024
Merged

fix(ffi): Add implementation of Niche for Option<Box<R>>#5094
mversic merged 1 commit intohyperledger-iroha:mainfrom
mversic:fix_ffi_option_box

Conversation

@mversic
Copy link
Copy Markdown
Contributor

@mversic mversic commented Sep 23, 2024

Context

  • Describe the objective or issue this PR addresses, as well as the impact of the change.
  • Try to keep the description accessible to newcomers.
  • If you're resolving a specific issue, add "Fixes #issue_number" or "Closes #issue_number".

Solution

  • Describe the approach taken to achieve the objective / resolve the issue.

Migration Guide (optional)

  • If this PR contains a breaking change relative to the main branch, provide an instruction on how affected parties might need to adapt to the change.

Review notes (optional)

  • For complex PRs, try to provide some information on how to approach the review more effectively.
  • For example, is there a natural order in which the affected files should be reviewed?

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@mversic mversic self-assigned this Sep 23, 2024
@mversic
fix(ffi): Add implementation of Niche for Option<Box<R>>
a68bc96 
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic merged commit 8580c57 into hyperledger-iroha:main Sep 23, 2024
@mversic mversic deleted the fix_ffi_option_box branch September 23, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

2 more reviewers

@nxsaken nxsaken nxsaken approved these changes

@Erigara Erigara Erigara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mversic mversic

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mversic @nxsaken @Erigara