refactor: make query cursor errors more specific#5086
Merged
nxsaken merged 5 commits intohyperledger-iroha:mainfrom Sep 19, 2024
nxsaken:refactor/unknown-cursor
Merged
refactor: make query cursor errors more specific#5086nxsaken merged 5 commits intohyperledger-iroha:mainfrom nxsaken:refactor/unknown-cursor
nxsaken merged 5 commits intohyperledger-iroha:mainfrom
nxsaken:refactor/unknown-cursor
Conversation
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
DCNick3
reviewed
Sep 18, 2024
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
DCNick3
approved these changes
Sep 18, 2024
Erigara
approved these changes
Sep 19, 2024
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
UnknownCursorerror more specific. There are several places with different logic where this error is returned (query not found, cursor mismatch, not enough items). Moves the error thrown on a query not being found in the store fromUnknownCursor.Checklist
CONTRIBUTING.md.