fix(p2p): disable sending message when not ready to prevent busy loop#5032
Merged
mversic merged 2 commits intohyperledger-iroha:mainfrom Sep 5, 2024
Merged
fix(p2p): disable sending message when not ready to prevent busy loop#5032mversic merged 2 commits intohyperledger-iroha:mainfrom
mversic merged 2 commits intohyperledger-iroha:mainfrom
Conversation
mversic
previously approved these changes
Sep 5, 2024
DCNick3
previously approved these changes
Sep 5, 2024
Contributor
DCNick3
left a comment
There was a problem hiding this comment.
Looks like a correct fix. Although tokio::select! is always tricky..
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Co-authored-by: ⭐️NINIKA⭐️ <DCNick3@users.noreply.github.com> Signed-off-by: Shanin Roman <40040452+Erigara@users.noreply.github.com>
530aeff to
7a8ba1b
Compare
mversic
approved these changes
Sep 5, 2024
DCNick3
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
It was observed that iroha consume a lot CPU in idle state, turned out it was due to accidental busy loop in p2p code.
Closes: #5033
Solution
Add conditional disabling sending message in
Peereven loop when there is no data to be sent to prevent busy loop.