Skip to content

refactor: Move total asset quantity to asset definition#5029

Merged
DCNick3 merged 2 commits intohyperledger-iroha:mainfrom
DCNick3:move-total-quantity-to-asset-definition
Sep 3, 2024
Merged

refactor: Move total asset quantity to asset definition#5029
DCNick3 merged 2 commits intohyperledger-iroha:mainfrom
DCNick3:move-total-quantity-to-asset-definition

Conversation

@DCNick3
Copy link
Copy Markdown
Contributor

@DCNick3 DCNick3 commented Sep 3, 2024

Context

total_asset_quantity map that we store is somewhat redundant and can be stored in the asset definition. This refactor allows us to remove FindTotalAssetQuantityByAssetDefinitionId query, as the total asset quantity can be found by querying the asset definition itself.

Closes #4934.

Solution

  • remove asset_total_quantities map from WSV
  • add total_quantity field to the AssetDefinition
  • remove FindTotalAssetQuantityByAssetDefinitionId query
  • replace test usages by the filtered FindAssetsDefinitions

Migration Guide

FindTotalAssetQuantityByAssetDefinitionId:

query(FindAssetsDefinitions::new())
  .filter_with(|asset_definition| asset_definition.id.eq(needle_definition_id))
  .execute_single()?
  .total_quantity

Checklist

@DCNick3
refactor: integrate the asset_total_quantities map into the asset d…
6dd92cd 
…efinition itself

Signed-off-by: ⭐️NINIKA⭐️ <dcnick3@users.noreply.github.com>
@DCNick3
refactor(queries): remove FindTotalAssetQuantityByAssetDefinitionId a…
13b030b 
…nd replace its usages

Signed-off-by: ⭐️NINIKA⭐️ <dcnick3@users.noreply.github.com>
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Sep 3, 2024
@DCNick3 DCNick3 added the queries label Sep 3, 2024
@DCNick3 DCNick3 merged commit 6613210 into hyperledger-iroha:main Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@mversic mversic Awaiting requested review from mversic mversic is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 is a code owner

2 more reviewers

@nxsaken nxsaken nxsaken approved these changes

@Erigara Erigara Erigara approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DCNick3 DCNick3

@Erigara Erigara

Labels

api-changes Changes in the API for client libraries queries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move asset_total_amount inside the asset definition

3 participants

@DCNick3 @nxsaken @Erigara