feat(queries): Report amount of remaining items in query#5016
Merged
mversic merged 3 commits intohyperledger-iroha:mainfrom Sep 4, 2024
Merged
feat(queries): Report amount of remaining items in query#5016mversic merged 3 commits intohyperledger-iroha:mainfrom
mversic merged 3 commits intohyperledger-iroha:mainfrom
Conversation
76149b1 to
7a70461
Compare
Contributor
|
How this will work for SDKs? To get total amount of items in the query they need to add number of remaining items (from the |
Contributor
Author
Yes, this is what rust SDK is also doing |
Erigara
previously approved these changes
Sep 3, 2024
mversic
previously approved these changes
Sep 4, 2024
Signed-off-by: ⭐️NINIKA⭐️ <dcnick3@users.noreply.github.com>
Signed-off-by: ⭐️NINIKA⭐️ <dcnick3@users.noreply.github.com>
7a70461 to
e71b780
Compare
…sedIterator::remaining` to hopefully be more clear Signed-off-by: ⭐️NINIKA⭐️ <dcnick3@users.noreply.github.com>
mversic
approved these changes
Sep 4, 2024
Erigara
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR allows the client to inspect the amount of items that is returned by the query without requesting all batches.
Closes #4984
Solution
ExactSizeIteratorimplementation applied to the pagination combinator. Filtering is not a problem, because we currently eagerly collect all items into a vector before returning anything.ExactSizeIteratoronQueryIteratorpretty naturally.Checklist
CONTRIBUTING.md.