fix: Leader as transaction ordering service by SamHSmith · Pull Request #4967 · hyperledger-iroha/iroha

SamHSmith · 2024-08-13T08:16:17Z

Description

#4914

Linked issue

Closes #{issue_number}

Benefits

Checklist

I've read CONTRIBUTING.md
I've used the standard signed-off commit format (or will squash just before merging)
All applicable CI checks pass (or I promised to make them pass later)
(optional) I've written unit tests for the code changes
I replied to all comments after code review, marking all implemented changes with thumbs up

mversic · 2024-08-13T09:34:59Z

you should follow the style of the code and add a new state to the block state machine. Let's consider this in more detail:

remove categorize_transactions function
make BlockBuilder::new -> BlockBuilder::chain -> BlockBuilder::sign produce SignedBlock(not ValidBlock)

Erigara

Is there is any performance boost measurements?

mversic

I don't see that CommittedTransaction::error is being updated anywhere

Signed-off-by: Sam H. Smith <sam.henning.smith@protonmail.com>

SamHSmith requested review from 0x009922, DCNick3, Erigara, dima74, mversic, outoftardis and s8sato as code owners August 13, 2024 08:16

SamHSmith marked this pull request as draft August 13, 2024 08:16

SamHSmith self-assigned this Aug 13, 2024

mversic reviewed Aug 13, 2024

View reviewed changes

Comment thread core/src/sumeragi/main_loop.rs Outdated

SamHSmith force-pushed the tx_order branch 2 times, most recently from c329d6c to 81e0bf2 Compare September 9, 2024 21:33

SamHSmith marked this pull request as ready for review September 9, 2024 21:35

SamHSmith force-pushed the tx_order branch 2 times, most recently from 619b997 to c89a385 Compare September 11, 2024 19:06

mversic reviewed Sep 12, 2024

View reviewed changes

Comment thread crates/iroha_core/src/sumeragi/message.rs

mversic requested changes Sep 12, 2024

View reviewed changes

Comment thread crates/iroha_core/src/sumeragi/message.rs

mversic self-assigned this Sep 15, 2024

mversic mentioned this pull request Sep 23, 2024

fix: put CommittedTransaction::error in block hash #5095

Closed

SamHSmith force-pushed the tx_order branch 3 times, most recently from cffd99b to 6a895c4 Compare September 25, 2024 07:16

mversic assigned Erigara Sep 26, 2024

Erigara reviewed Sep 26, 2024

View reviewed changes

Comment thread crates/iroha_core/src/sumeragi/main_loop.rs Outdated

Comment thread crates/iroha_core/src/sumeragi/main_loop.rs

Comment thread crates/iroha_core/src/sumeragi/main_loop.rs

mversic requested changes Sep 27, 2024

View reviewed changes

Comment thread crates/iroha_data_model/src/block.rs Outdated

Comment thread crates/iroha_core/src/block.rs Outdated

SamHSmith force-pushed the tx_order branch from 6a895c4 to fda1bd5 Compare September 29, 2024 15:59

mversic reviewed Sep 29, 2024

View reviewed changes