fix(client): Fix torii url with path#4903
Merged
dima74 merged 2 commits intohyperledger-iroha:mainfrom Jul 29, 2024
Merged
Conversation
0x009922
previously approved these changes
Jul 29, 2024
Contributor
0x009922
left a comment
There was a problem hiding this comment.
Would be also nice to add simple unit tests covering join_torii_url and user config transformations.
nxsaken
previously approved these changes
Jul 29, 2024
DCNick3
previously approved these changes
Jul 29, 2024
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
93eb2b7 to
e2ba1fd
Compare
nxsaken
approved these changes
Jul 29, 2024
DCNick3
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consider
client.toml:Currently
/peer-1/part will be ignored and queries will be send tohttp://iroha-test.com/query. This PR fixes itBenefits
Fix using
torii_urlwith path inclient.tomlChecklist
CONTRIBUTING.md