PR description

Address case where the pure java p256Verify implementation was not explicitly checking the public-key input is on-curve prior to verifying the signature. This code path is not part of mainnet ethereum, but some specific configurations of besu on a dev net could have triggered this exception:

Invalid point coordinates
java.lang.IllegalArgumentException: Invalid point coordinates
	at org.bouncycastle.math.ec.ECCurve.validatePoint(Unknown Source)
	at org.bouncycastle.math.ec.ECCurve.decodePoint(Unknown Source)
	at org.hyperledger.besu.crypto.AbstractSECP256.verify(AbstractSECP256.java:373)
	at org.hyperledger.besu.crypto.SECP256R1.verifyMalleable(SECP256R1.java:132)
	at org.hyperledger.besu.evm.precompile.P256VerifyPrecompiledContract.computeDefault(P256VerifyPrecompiledContract.java:237)
	at org.hyperledger.besu.evm.precompile.P256VerifyPrecompiledContractTest.testInvalidCurvePointReturnsInvalid(P256VerifyPrecompiledContractTest.java:123)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

Which would have caused these specifically configured instances of besu to refuse to import or create a block with such an invalid public key rely on exceptional logic to attribute the precompile result as invalid, rather than proactively checking the public key is valid.

Thx @0xMushow for probing about point-validity in the besu implementation of eip-7951.

Fixed Issue(s)

adds point-on-curve check in the pure java bouncy castle implementation, and adds unit tests to assert the behavior across pure java and native implementation.

Thanks for sending a pull request! Have you done the following?

• Checked out our contribution guidelines?
• Considered documentation and added the doc-change-required label to this PR if updates are required.
• Considered the changelog and included an update if required.
• For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

• spotless: ./gradlew spotlessApply
• unit tests: ./gradlew build
• acceptance tests: ./gradlew acceptanceTest
• integration tests: ./gradlew integrationTest
• reference tests: ./gradlew ethereum:referenceTests:referenceTests
• hive tests: Engine or other RPCs modified?