feat: Add tcp setting getters to endpoint #1983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add getters for tcp settings to Endpoints. The purpose for this is that `connect_with_connector` doesn't set TCP settings on the socket, because it's using a provided connector. In the cases where a library is creating a custom TCP connection, we want to be able to respect user tcp settings, in particular connection timeout. Adding these getters allows this.
djc
reviewed
Oct 9, 2024
djc
approved these changes
Oct 9, 2024
ikrivosheev
approved these changes
Oct 9, 2024
tottoto
approved these changes
Oct 13, 2024
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add getters for tcp settings to Endpoints. The purpose for this is that
connect_with_connectordoesn't set TCP settings on the socket, because it's using a provided connector. In the cases where a library is creating a custom TCP connection, we want to be able to respect user tcp settings, in particular connection timeout. Adding these getters allows this.Motivation
The purpose for this is that
connect_with_connectordoesn't set TCP settings on the socket, because it's using a provided connector. In the cases where a library is creating a custom TCP connection, we want to be able to respect user tcp settings, in particular connection timeout. Adding these getters allows this.Solution
Adds simple getters for existing tcp settings on an endpoint.