feat(service): Add Layered service to propagate NamedService implementation #1966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@mrmeku Does this meet your requirements? |
djc
reviewed
Oct 1, 2024
Absolutely. Great solution |
Collaborator
Author
|
@mrmeku Thanks for confirming. |
c9b556a to
28cd1e9
Compare
djc
approved these changes
Oct 2, 2024
Collaborator
Author
|
Added a test. |
5320842 to
2623211
Compare
2623211 to
a7057fa
Compare
djc
approved these changes
Oct 3, 2024
a7057fa to
cdc3034
Compare
Collaborator
Author
|
Squashed the commits. |
cdc3034 to
f18f8a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Layeredservice to propagateNamedServiceimplementation.Resolves #1958.