fix(tonic-web): fix panic caused in trailer parsing when there is more than one trailer #1880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakhenry
commented
Aug 21, 2024
af26d0d to
aaa1bb5
Compare
djc
approved these changes
Aug 21, 2024
Contributor
djc
left a comment
There was a problem hiding this comment.
I think this makes sense, but the code is a little hard to read.
…e than one trailer
aaa1bb5 to
ac8bc48
Compare
djc
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
Motivation
Attempting to parse a real grpc-web message response from an envoy server that added a few other trailers resulted in a panic
Solution
Root issue was a simple failure to advance the cursor in a buffer read. It happened to work for the first trailer so this wasn't already caught in tests