Adds max_pending_accept_reset_streams for legacy
#102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds this missing function to the legacy client.
17 tasks
tisonkun
reviewed
Apr 19, 2024
Contributor
tisonkun
left a comment
There was a problem hiding this comment.
Compile failed. Shall we rebase on the latest master to get the field added?
Signed-off-by: tison <wander4096@gmail.com>
Contributor
|
Seems the code itself is wrong. I made a patch at #119. @allan2 Feel free to merge my commit into this patch. Or @seanmonstar can review #119 instead as I'll actively respond. Credits are retained. My main target is moving this forward and then hyperium/tonic#1670. |
Contributor
Author
seanmonstar
approved these changes
Apr 25, 2024
|
Here you need to update the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds this missing function to the legacy client.
#90 was merged with half of #78. This PR is the other half.