Fix manual_assert lint#4079
Merged
Merged
Conversation
560c801 to
1b8934f
Compare
Contributor
Author
|
For some reason the fmt command in the contributing docs changes nothing for me on the same rustfmt version... Applying manually |
Member
|
Yea, |
Contributor
Author
|
So the command the job printed out didn't do anything on my system... I did already try it 😓 EDIT: Seemed it worked if I ran it inside the src dir just not in the project root.... No idea why though 🫠 |
As per hyperium#4071 fix instances where the manual_assert lint triggered on the code. This was able to be done with a `clippy --fix` with further cleanup to change `!<expr>.is_some()` in the assert to `<expr>.is_none()`.
1b8934f to
4365d57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #4071 fix instances where the manual_assert lint triggered on the code. This was able to be done with a
clippy --fixwith further cleanup to change!<expr>.is_some()in the assert to<expr>.is_none().