refactor(clippy): Reduce some Clippy warnings#3805
Merged
seanmonstar merged 1 commit intohyperium:masterfrom Dec 6, 2024
Merged
refactor(clippy): Reduce some Clippy warnings#3805seanmonstar merged 1 commit intohyperium:masterfrom
seanmonstar merged 1 commit intohyperium:masterfrom
Conversation
4ea0be0 to
9dc5525
Compare
seanmonstar
reviewed
Dec 3, 2024
seanmonstar
approved these changes
Dec 6, 2024
Member
seanmonstar
left a comment
There was a problem hiding this comment.
Perfect, good work, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR want to do
Tried to complete #3802 as well as possible.
This PR wants to reduce some Clippy warnings that worth fixing. Almost all of the changes are based on clippy prompts. And passed the MSRV 1.63 test.
Some of the warnings have not changed, mainly based on Clippy's false positives, and some clippy rules are newer than the current MSRV 1.63.
How to test and review
Needs downgrade some crate versions to run on MSRV 1.63.
Run
cargo +1.63-x86_64-unknown-linux-gnu clippy --workspace --no-deps --all-targets --features="full" -- -D warningsThe warnings/error reduces to 7.