proto/h1/server: avoid copy-allocation in request path parsing #3575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
627dac7 to
977d42e
Compare
This tweaks the request path parsing logic (in server role) in order to perform zero-copy URI parsing.
977d42e to
bc28ba7
Compare
seanmonstar
approved these changes
Feb 21, 2024
sfackler
reviewed
Feb 21, 2024
| let bytes_ptr = bytes.as_ptr() as usize; | ||
| let start = req_path.as_ptr() as usize - bytes_ptr; | ||
| let end = start + req_path.len(); | ||
| std::ops::Range { start, end } |
Contributor
There was a problem hiding this comment.
This can just be start..end fyi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweaks the request path parsing logic (in server role) in order to perform zero-copy URI parsing.
Closes: #3574