Refactor: assorted code readability improvements in h1/conn.rs#2817
Merged
seanmonstar merged 13 commits intohyperium:masterfrom Apr 26, 2022
BastiDood:assorted-refactoring
Merged
Refactor: assorted code readability improvements in h1/conn.rs#2817seanmonstar merged 13 commits intohyperium:masterfrom BastiDood:assorted-refactoring
h1/conn.rs#2817seanmonstar merged 13 commits intohyperium:masterfrom
BastiDood:assorted-refactoring
Conversation
It turns out `Copy` was not implemented. Oops!
seanmonstar
approved these changes
Apr 26, 2022
Member
seanmonstar
left a comment
There was a problem hiding this comment.
Thanks so much! This does indeed improve readability in various places. I did leave a comment inline, but I don't know if I want action on it or not... mostly just want to make a record of it...
seanmonstar
reviewed
Apr 26, 2022
BastiDood
commented
Apr 26, 2022
Contributor
Author
|
Everything seems to be in order now. Please do let me know if there are any other concerns. Thanks! |
Member
|
Very nice, thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there! This PR features assorted refactoring techniques that hopefully improves readability. No behavior change is expected.
Most of the refactoring involved using the
matches!macro instead of explicit Booleanmatchexpressions. Other refactoring involved transforming logic to early returns. The overall result is that the code is now a little bit less nested. 🎉With that said, please feel free to inform me if some of the changes need improvement. Thanks!