Skip to content

Update Tokio, bytes, http, h2, and http-body#2030

Merged
seanmonstar merged 1 commit intomasterfrom
tokio-up
Dec 4, 2019
Merged

Update Tokio, bytes, http, h2, and http-body#2030
seanmonstar merged 1 commit intomasterfrom
tokio-up

Conversation

@seanmonstar
Copy link
Copy Markdown
Member

Closes #2025

Copy link
Copy Markdown
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seanmonstar seanmonstar force-pushed the tokio-up branch 6 times, most recently from 4b201e3 to 9430566 Compare December 4, 2019 03:19
@CryZe CryZe mentioned this pull request Dec 4, 2019
6 tasks
@jeromegn
Copy link
Copy Markdown

jeromegn commented Dec 4, 2019

I've been playing with this branch and I noticed Body doesn't support try_concat anymore with futures 0.3 since Chunk would need to implement Extend<u8> according to the new function signature.

the trait bound `hyper::body::chunk::Chunk: std::iter::Extend<u8>` is not satisfied
required because of the requirements on the impl of `core::future::future::Future` for `futures_util::stream::try_stream::try_concat::TryConcat<&mut hyper::body::body::Body>`

@seanmonstar
Copy link
Copy Markdown
Member Author

Body doesn't support try_concat anymore

True, this is because Bytes (and thus Chunk) no longer implement Extend<u8>, since they are meant to be a frozen item. I have plans to add some alternatives to the http-body trait.

@seanmonstar seanmonstar merged commit cb3f39c into master Dec 4, 2019
@seanmonstar seanmonstar deleted the tokio-up branch December 4, 2019 18:56
@o01eg
Copy link
Copy Markdown

o01eg commented Dec 4, 2019

@seanmonstar What about BytesMut ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to tokio 0.2

5 participants