-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Document Drop behavior for Connection types #3192
Copy link
Copy link
Closed
Labels
A-clientArea: client.Area: client.A-docsArea: documentation.Area: documentation.C-featureCategory: feature. This is adding a new feature.Category: feature. This is adding a new feature.E-easyEffort: easy. A task that would be a great starting point for a new contributor.Effort: easy. A task that would be a great starting point for a new contributor.
Description
Metadata
Metadata
Assignees
Labels
A-clientArea: client.Area: client.A-docsArea: documentation.Area: documentation.C-featureCategory: feature. This is adding a new feature.Category: feature. This is adding a new feature.E-easyEffort: easy. A task that would be a great starting point for a new contributor.Effort: easy. A task that would be a great starting point for a new contributor.
Type
Fields
Give feedbackNo fields configured for issues without a type.
This is not per se feature, but rather documentatation issue.
Current documentation for
Connectiontypes is very limited to understand its behaviorhttps://docs.rs/hyper/1.0.0-rc.3/hyper/client/conn/http1/struct.Connection.html
https://docs.rs/hyper/1.0.0-rc.3/hyper/client/conn/http2/struct.Connection.html
It asks to poll it, but it doesn't say what will happen if you drop it (due to panic or other reasons)
It would be good to add more details on its behavior so that user could be confident in how to handle it after request had been handled