Skip to content

Commit cca6bf1

Browse files
authored
style(client): removing wildcard_imports lint allowance (#4080)
The wildcard_imports used in http1.rs is replaced with explict type imports.
1 parent 3cc1158 commit cca6bf1

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,6 @@ unused_trait_names = "allow" # TODO: kinda annoying, but might be good to deny
169169
unwrap_in_result = "allow"
170170
useless_borrows_in_formatting = "allow"
171171
wildcard_enum_match_arm = "allow"
172-
wildcard_imports = "allow" # TODO: never, except for tests
173172

174173
# explicitly allowed
175174
absolute_paths = "allow" # sometimes its cleaner

src/client/conn/http1.rs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -591,10 +591,11 @@ impl Builder {
591591
}
592592

593593
mod upgrades {
594+
use super::{Connection, Context, Future, Parts, Pin, Poll, Read, StdError, Write};
595+
use crate::body::Body;
596+
use crate::proto::Dispatched;
594597
use crate::upgrade::Upgraded;
595-
596-
use super::*;
597-
598+
use futures_core::ready;
598599
// A future binding a connection with a Service with Upgrade support.
599600
//
600601
// This type is unnameable outside the crate.
@@ -628,8 +629,8 @@ mod upgrades {
628629
)
629630
.poll(cx))
630631
{
631-
Ok(proto::Dispatched::Shutdown) => Poll::Ready(Ok(())),
632-
Ok(proto::Dispatched::Upgrade(pending)) => {
632+
Ok(Dispatched::Shutdown) => Poll::Ready(Ok(())),
633+
Ok(Dispatched::Upgrade(pending)) => {
633634
let Parts { io, read_buf } = self
634635
.inner
635636
.take()

0 commit comments

Comments
 (0)