Override some provided Iterator methods for header map's Keys#667
Merged
seanmonstar merged 1 commit intohyperium:masterfrom Jan 29, 2024
Merged
Override some provided Iterator methods for header map's Keys#667seanmonstar merged 1 commit intohyperium:masterfrom
Iterator methods for header map's Keys#667seanmonstar merged 1 commit intohyperium:masterfrom
Conversation
The `inner` iterator is simply a `slice::Iter`, so all of these can be done in constant time. Ideally, we would override `advance_by`, but that's still unstable.
seanmonstar
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
inneriterator is simply aslice::Iter, so all of these can be done in constant time. Ideally, we would overrideadvance_by, but that's still unstable.With this, it is possible to build a poor man's
retain, which was requested in #541. On that topic: would you be open to merge a PR addingretain? Then I might start working on that.