From impls of PathAndQuery and Authority for Uri#538
Merged
seanmonstar merged 2 commits intohyperium:masterfrom Apr 28, 2022
Merged
From impls of PathAndQuery and Authority for Uri#538seanmonstar merged 2 commits intohyperium:masterfrom
seanmonstar merged 2 commits intohyperium:masterfrom
Conversation
Closed
robjtede
approved these changes
Apr 26, 2022
robjtede
left a comment
There was a problem hiding this comment.
Seems reasonable to add these shortcuts. Both forms are constructable in other ways.
Might be good to add a couple tests anyway just so that any future internal changes don't accidentally allow these impls to construct invalid URIs.
seanmonstar
approved these changes
Apr 27, 2022
Contributor
Author
|
@seanmonstar #499 required 1.49, but it looks like the CI is still trying to build with 1.46. |
Member
|
I think it's because it's commits from before the updated MSRV. The list says 1.49 is required but not running. |
A Uri may logically hold only an Authority or only a PathAndQuery. Should an application want to make such Uris, it would be easier to safely create them by first making just an Authority or just a PathAndQuery, then cheaply convert them directly into a Uri.
The doc comments for `impl From<Uri> for Parts` actually described `Uri::from_parts`.
Contributor
Author
|
That makes sense too... I've rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Uri may logically hold only an Authority or only a PathAndQuery.
Should an application want to make such Uris, it would be easier to
safely create them by first making just an Authority or just a
PathAndQuery, then cheaply convert them directly into a Uri.