allow servers to receive requests without an :authority header#372
Merged
seanmonstar merged 1 commit intomasterfrom Jun 17, 2019
Merged
allow servers to receive requests without an :authority header#372seanmonstar merged 1 commit intomasterfrom
seanmonstar merged 1 commit intomasterfrom
Conversation
This was referenced Jun 17, 2019
olix0r
approved these changes
Jun 17, 2019
| } | ||
|
|
||
| // A request translated from HTTP/1 must not include the :authority | ||
| // header |
Collaborator
There was a problem hiding this comment.
If a host header is present do we have any obligation to validate it?
Member
Author
There was a problem hiding this comment.
I can't find anything in the HTTP2 spec stating to do anything with a received host header besides handling it like any other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code before tried to allow these requests, but then the
request::Builderwould error trying to construct aUriwith only the scheme and path. Now, if there is no authority, the scheme is dropped.Closes #345