Skip to content

Add a setter for header_table_size #637

@4JX

Description

@4JX

I'd like to make a PR to uncomment the setter for header_table_size, found here:

h2/src/frame/settings.rs

Lines 124 to 128 in 87969c1

/*
pub fn set_header_table_size(&mut self, size: Option<u32>) {
self.header_table_size = size;
}
*/

When playing around with the setter I found out that connections would sometimes fail the following check, Since the decoder's size is never updated from the default DEFAULT_SETTINGS_HEADER_TABLE_SIZE.

h2/src/hpack/decoder.rs

Lines 256 to 258 in 88b0789

if new_size > self.last_max_update {
return Err(DecoderError::InvalidMaxDynamicSize);
}

Would this be the place to fix that?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions