Skip to content

Conversation

@huangdijia
Copy link
Member

Summary

This PR completes the terminology standardization in the async-queue component by renaming the remaining queue-related identifiers to pool-related ones. This change aligns with the recent refactoring in #7615 where the $queue property was renamed to $pool in ConsumerProcess.

Changes

  • Renamed JobInterface::getQueueName() to getPoolName()
  • Renamed Job::getQueueName() to getPoolName()
  • Renamed $queue parameter to $pool in dispatch() function

Motivation

The async-queue component uses "pool" terminology to refer to different queue configurations (e.g., "default", "custom"). This refactoring ensures consistency across the codebase by using "pool" instead of "queue" in method and parameter names.

Breaking Changes

⚠️ This is a breaking change for v3.2

Classes implementing JobInterface will need to rename getQueueName() to getPoolName():

// Before
public function getQueueName(): string
{
    return 'default';
}

// After
public function getPoolName(): string
{
    return 'default';
}

Test Plan

  • Verify all async-queue tests pass
  • Verify no other references to getQueueName() exist in the codebase
  • Test job dispatching works correctly with the renamed method

…ency

This change completes the terminology standardization in the async-queue component by renaming the remaining queue-related identifiers to pool-related ones, aligning with the ConsumerProcess refactoring in hyperf#7615.

Changes:
- Renamed JobInterface::getQueueName() to getPoolName()
- Renamed Job::getQueueName() to getPoolName()
- Renamed $queue parameter to $pool in dispatch() function
@huangdijia huangdijia added this to the v3.2 milestone Nov 14, 2025
@limingxinleo limingxinleo merged commit 54b2ecb into hyperf:3.2 Nov 14, 2025
76 checks passed
@huangdijia huangdijia deleted the refactor/async-queue-rename-queue-to-pool branch November 14, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants