refactor(async-queue): remove JobMessage backward compatibility code #7609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove deprecated backward compatibility code from JobMessage class that was maintaining support for the old serialization format. This code was marked for removal in v3.2 and is no longer needed. Changes: - Remove legacy array-based serialization format from __serialize() - Remove compatibility check in __unserialize() for array_is_list format - Keep only the associative array format with 'job' and 'attempts' keys
limingxinleo
approved these changes
Nov 10, 2025
Removed the OldJobMessage stub and related compatibility tests from JobMessageTest. Updated serialization assertions and adjusted RedisDriverTest to reflect new serialized length. This streamlines the test suite and removes legacy code.
limingxinleo
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test plan