refactor(testing): add NonCoroutine attribute for flexible test execution control #7605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion control - Added NonCoroutine attribute to disable coroutine execution for specific tests - Refactored RunTestsInCoroutine trait to use attribute-based detection - Removed hardcoded $enableCoroutine property in favor of reflection-based approach - Added isCoroutineEnabled() method to check class and method attributes - Improved code maintainability and flexibility for test execution control
…onCoroutine attribute functionality
limingxinleo
approved these changes
Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NonCoroutineattribute to provide fine-grained control over coroutine execution in testsRunTestsInCoroutinetrait to use reflection-based attribute detection$enableCoroutineproperty in favor of a more flexible approachisCoroutineEnabled()method that checks both class-level and method-level attributesChanges
Hyperf\Testing\Attributes\NonCoroutineattribute that can be applied to test classes or methods to disable coroutine executionprotected bool $enableCoroutine = true;propertyisCoroutineEnabled()method using reflection to check for NonCoroutine attributesRunTestsInCoroutineTestto verify the functionalityBenefits
Test Plan