Skip to content

Optimized AnnotationJob to support call protected / private methods. #7604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
limingxinleo merged 6 commits into from
Nov 8, 2025
Merged

Optimized AnnotationJob to support call protected / private methods. #7604

limingxinleo merged 6 commits into from
Nov 8, 2025

Conversation

@huangdijia
Copy link
Member

@huangdijia huangdijia commented Nov 7, 2025

Summary

This PR refactors the AnnotationJob class to modernize the code with PHP 8.0+ features and improve code clarity.

Changes

  • Constructor Property Promotion: Converted class properties to use constructor property promotion, reducing boilerplate code
  • Code Cleanup: Removed redundant variable assignments and improved code structure
  • Method Invocation: Used arrow function with ->call() for cleaner method invocation on the instance
  • Formatting: Improved overall code formatting and readability

Technical Details

The refactoring maintains backward compatibility while:

  • Reducing the number of lines of code from 57 to 49
  • Eliminating manual property assignments in the constructor
  • Simplifying the handle() method logic
  • Using modern PHP syntax features

Impact

  • No breaking changes to the public API
  • All existing functionality remains intact
  • Improved code maintainability and readability

huangdijia and others added 5 commits November 7, 2025 10:37
@huangdijia
refactor(async-queue): modernize AnnotationJob with constructor promo…
cbc21e8 
…tion and clean up code

- Convert class properties to constructor property promotion (PHP 8.0+)
- Simplify code structure and improve readability
- Use arrow function with ->call() for method invocation
- Clean up formatting and remove redundant variable assignments
- Maintain backward compatibility with existing functionality
@huangdijia
优化 CHANGELOG，添加对 AnnotationJob 的优化说明以支持调用保护/私有方法
db56277
@limingxinleo
Merge branch 'master' into pr/7604
6df4cb2
@limingxinleo
Fixed bug
f815728
@huangdijia
refactor(test): update testAnnotationJob to mock container and use Wa…
c3fdd0c 
…iter
@huangdijia huangdijia changed the title refactor(async-queue): modernize AnnotationJob with constructor promotion and clean up code Optimized AnnotationJob to support call protect / private methods. Nov 8, 2025
@huangdijia huangdijia changed the title Optimized AnnotationJob to support call protect / private methods. Optimized AnnotationJob to support call protected / private methods. Nov 8, 2025
huangdijia
huangdijia commented Nov 8, 2025
View reviewed changes
@limingxinleo limingxinleo merged commit 78fee17 into hyperf:master Nov 8, 2025
74 checks passed
@huangdijia huangdijia deleted the refactor/async-queue-annotation-job branch November 8, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@limingxinleo limingxinleo limingxinleo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@huangdijia @limingxinleo