refactor(async-queue): strengthen Result type handling in Driver and AfterHandle event #7603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resultenum, defaulting toResult::ACKfor non-Result returnsdefaultcase from match expression since allResultcases are explicitly handledAfterHandleevent's$resultproperty from nullableResultto requiredResulttypeResulttype check when dispatchingAfterHandleeventChanges
Driver.php (src/async-queue/src/Driver/Driver.php:123-132)
$result = $result instanceof Result ? $result : Result::ACK;default => $this->ack($data)case from match expressionAfterHandledispatch to pass$resultdirectly without type checkAfterHandle.php (src/async-queue/src/Event/AfterHandle.php:20)
public ?Result $result = nulltopublic Result $resultBenefits
AfterHandleevent always receives a validResultenum valueResultenum will automatically getResult::ACKbehaviorResultenum typeTest plan
Resultenum values (ACK,REQUEUE,RETRY,DROP)ACK)AfterHandleevent listeners receive properResultvalues