fix(async-queue): relax type hint for callback message parameter #7602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the PHPDoc type hint for the `$message` parameter in the `getCallback()` method from `MessageInterface` to `MessageInterface|mixed` to better reflect the actual usage pattern and improve type compatibility with the recent result handling implementation.
limingxinleo
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
$messageparameter in thegetCallback()method fromMessageInterfacetoMessageInterface|mixedMotivation
This change improves type compatibility following the recent result handling implementation added in commit 196f346. The method needs to handle cases where the message parameter might not strictly be a
MessageInterfaceinstance, as evidenced by the instanceof check on line 114.Changes
src/async-queue/src/Driver/Driver.php:108Test plan