Skip to content

Fixed BC when validation rule not define. #7596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
limingxinleo merged 5 commits into from
Nov 4, 2025
Merged

Fixed BC when validation rule not define. #7596

limingxinleo merged 5 commits into from
Nov 4, 2025

Conversation

@xuanyanwow
Copy link
Member

@xuanyanwow xuanyanwow commented Nov 4, 2025

Old version code :

return Arr::only($rules, $this->scenes[$scene]);

New version code:

 if (is_string($key)) {
    $result[$key] = $value;
} elseif (is_numeric($key) && is_string($value)) {
    $result[$value] = $rules[$value];
}

Question:
If rule not define some filed, the version will throw some warning / exception.

@xuanyanwow xuanyanwow changed the title Fixed Validation BC when rule not define. Fixed BC when validation rule not define. Nov 4, 2025
@limingxinleo limingxinleo merged commit bbcad35 into master Nov 4, 2025
150 checks passed
@limingxinleo limingxinleo deleted the siam/fixed-validation branch November 4, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huangdijia huangdijia huangdijia approved these changes

@limingxinleo limingxinleo limingxinleo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xuanyanwow @huangdijia @limingxinleo