refactor(testing): optimize ClassLoader detection in phpunit-patch #7592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed from checking hardcoded autoload file paths to using spl_autoload_functions() to detect the Composer ClassLoader. This approach is more reliable and works regardless of the project structure.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the PHPUnit patch initialization logic to use registered autoloaders instead of checking hardcoded file paths. The change improves flexibility by allowing the code to work in different project structures without relying on specific vendor directory locations.
- Replaces hardcoded file path checking with
spl_autoload_functions()to dynamically discover the Composer ClassLoader - Simplifies the null check for the
$classLoadervariable - Removes the explicit
instanceofcheck when testing for null
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
limingxinleo
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
spl_autoload_functions()instead of checking hardcoded autoload file pathsChanges
src/testing/phpunit-patch.phpto iterate through registered autoload functionsBenefits