Fixed PHPStan type assertions in database model types #7583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated return type assertions for findOr() and firstOr() methods
to use literal type format (42|User instead of User|int)
- Fixed string literal type assertion in Collection::find()
to use single-quoted format ('string'|User instead of string|User)
These changes ensure PHPStan properly recognizes the literal types
in the type analysis tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed PHPStan type assertions in database model type test files to ensure proper literal type recognition.
Changes
Test plan
These changes ensure PHPStan properly recognizes the literal types in the type analysis tests.