Upgrade to nikic/php-parser v5 and update parser usage #7566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump nikic/php-parser dependency to ^5.0 across all relevant composer.json files. Refactor codebase to replace deprecated ParserFactory::ONLY_PHP7 and ParserFactory::PREFER_PHP7 usages with createForNewestSupportedVersion(). Update type handling and test assertions for compatibility with php-parser v5. Adjust code generation and test expectations to match new parser output and syntax formatting.
Removed direct usage of PhpParser\Lexer and Emulative in favor of using the Parser's getTokens() method. This simplifies the code and reduces dependency on the Lexer, aligning with updated PhpParser usage patterns.
Standardized spacing in type hints and array syntax in test files for consistency. No functional changes were made.
This reverts commit a04ed83.
limingxinleo
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump nikic/php-parser dependency to ^5.0 across all relevant composer.json files. Refactor codebase to replace deprecated ParserFactory::ONLY_PHP7 and ParserFactory::PREFER_PHP7 usages with createForNewestSupportedVersion(). Update type handling and test assertions for compatibility with php-parser v5. Adjust code generation and test expectations to match new parser output and syntax formatting.