Made Hyperf\Kafka\Annotation\Consumer::$pool empty by default
#7547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR changes the default value of the $pool parameter in the Kafka Consumer annotation from 'default' to an empty string, addressing issue #7546.
- Modified the default pool parameter value in the Consumer annotation class
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
22
to
+25
| * @param string|string[] $topic | ||
| */ | ||
| public function __construct( | ||
| public string $pool = 'default', | ||
| public string $pool = '', |
There was a problem hiding this comment.
Setting an empty string as the default for $pool may cause issues if the consuming code expects a non-empty pool identifier. Consider adding validation or documentation to clarify how empty pool values should be handled by consumers of this annotation.
limingxinleo
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on issue #7546