fix(command): add coordinator cleanup in command execution finally block #7545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add CoordinatorManager::until(Constants::WORKER_EXIT)->resume() in finally block - Ensure proper cleanup of coordinators after command execution - Wrap in try-catch to prevent exceptions from interrupting cleanup flow
There was a problem hiding this comment.
Pull Request Overview
This PR adds coordinator cleanup functionality to command execution by implementing CoordinatorManager::until(Constants::WORKER_EXIT)->resume() in the finally block of command execution. This ensures proper cleanup of coordinators after commands complete while preventing cleanup exceptions from interfering with the command flow.
- Added coordinator cleanup in the command execution finally block with proper exception handling
- Added the hyperf/coordinator dependency to the command package
- Deprecated the existing ResumeExitCoordinatorListener as it's being replaced by this new implementation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/command/src/Command.php | Added coordinator cleanup logic in finally block with try-catch protection |
| src/command/composer.json | Added hyperf/coordinator dependency |
| src/coordinator/src/Listener/ResumeExitCoordinatorListener.php | Deprecated listener and commented out its functionality |
| CHANGELOG-3.1.md | Added changelog entry for the optimization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
limingxinleo
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
CoordinatorManager::until(Constants::WORKER_EXIT)->resume()in the finally blockHyperf\Coordinator\ConstantsandHyperf\Coordinator\CoordinatorManagerTest plan