fix(main): Don't migrate in new plugins if --no-migrate is used (cloudquery#12962)

candiduslynx · web-flow · commit 2b3ede775abf · 2023-08-09T16:14:11.000Z
diff --git a/cli/cmd/sync_v3.go b/cli/cmd/sync_v3.go
@@ -21,7 +21,7 @@ import (
 )
 
 // nolint:dupl
-func syncConnectionV3(ctx context.Context, sourceClient *managedplugin.Client, destinationsClients managedplugin.Clients, sourceSpec specs.Source, destinationSpecs []specs.Destination, uid string, _ bool) error {
+func syncConnectionV3(ctx context.Context, sourceClient *managedplugin.Client, destinationsClients managedplugin.Clients, sourceSpec specs.Source, destinationSpecs []specs.Destination, uid string, noMigrate bool) error {
 	var mt metrics.Metrics
 	var exitReason = ExitReasonStopped
 	tables := make(map[string]bool, 0)
@@ -197,6 +197,9 @@ func syncConnectionV3(ctx context.Context, sourceClient *managedplugin.Client, d
 				}
 			}
 		case *plugin.Sync_Response_MigrateTable:
+			if noMigrate {
+				continue
+			}
 			sc, err := plugin.NewSchemaFromBytes(m.MigrateTable.Table)
 			if err != nil {
 				return err

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ import (`
`21`	`21`	`)`
`22`	`22`
`23`	`23`	`// nolint:dupl`
`24`		`-func syncConnectionV3(ctx context.Context, sourceClient *managedplugin.Client, destinationsClients managedplugin.Clients, sourceSpec specs.Source, destinationSpecs []specs.Destination, uid string, _ bool) error {`
	`24`	`+func syncConnectionV3(ctx context.Context, sourceClient *managedplugin.Client, destinationsClients managedplugin.Clients, sourceSpec specs.Source, destinationSpecs []specs.Destination, uid string, noMigrate bool) error {`
`25`	`25`	`var mt metrics.Metrics`
`26`	`26`	`var exitReason = ExitReasonStopped`
`27`	`27`	`tables := make(map[string]bool, 0)`
`@@ -197,6 +197,9 @@ func syncConnectionV3(ctx context.Context, sourceClient *managedplugin.Client, d`
`197`	`197`	`}`
`198`	`198`	`}`
`199`	`199`	`case *plugin.Sync_Response_MigrateTable:`
	`200`	`+ if noMigrate {`
	`201`	`+ continue`
	`202`	`+ }`
`200`	`203`	`sc, err := plugin.NewSchemaFromBytes(m.MigrateTable.Table)`
`201`	`204`	`if err != nil {`
`202`	`205`	`return err`