Skip to content

[2.x] Improved dynamic Markdown links #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emmadesilva merged 40 commits into from
Jul 25, 2024
Merged

[2.x] Improved dynamic Markdown links #1901

emmadesilva merged 40 commits into from
Jul 25, 2024

Conversation

@emmadesilva
Copy link
Member

@emmadesilva emmadesilva commented Jul 24, 2024 •
edited
Loading

This is part of something bigger.

Please see #1590 for information.

@emmadesilva emmadesilva force-pushed the improved-dynamic-markdown-links branch from 5e258bc to a83f81c Compare July 24, 2024 20:25
@emmadesilva emmadesilva force-pushed the improved-dynamic-markdown-links branch from b0a6001 to d4d8762 Compare July 24, 2024 20:26
@codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9589bc1) to head (4a46a58).

Additional details and impacted files 
@@                    Coverage Diff                     @@
##             dynamic-markdown-links     #1901   +/-   ##
==========================================================
  Coverage                    100.00%   100.00%           
- Complexity                     1870      1876    +6     
==========================================================
  Files                           192       192           
  Lines                          4941      4954   +13     
==========================================================
+ Hits                           4941      4954   +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmadesilva emmadesilva force-pushed the improved-dynamic-markdown-links branch from ae55e3b to 9e613da Compare July 25, 2024 08:31
emmadesilva added 24 commits July 25, 2024 10:32
@emmadesilva
Prepare to refactor proof of concept
6a5f159 
Want to reimplement these a bit better

Revert "New proof of concept"

This reverts commit d4d8762.

Revert "Improve proof of concept"

This reverts commit 9e613da.
@emmadesilva
Document new dynamic Markdown link feature spec
9c19e50
@emmadesilva
Remove the patterns method
70deb8c
@emmadesilva
Remove the patterns loop
780b871
@emmadesilva
Remove unused import
dee2c96
@emmadesilva
Draft new processing loop
642ec73
@emmadesilva
Convert concatenation to 'sprintf()' calls
2b35be2
@emmadesilva
Implement the route map method
2afc335
@emmadesilva
Implement the asset map method
04a0a7c
@emmadesilva
Implement the asset path method
48efa5e
@emmadesilva
Add todo
f8c2c22
@emmadesilva
Update imports
b5d8f71
@emmadesilva
Add import
37b8f84
@emmadesilva
Update route mocks
a44357d
@emmadesilva
Remove old exception test
c175cb5
@emmadesilva
Remove old fault tolerance tests
a8be72d
@emmadesilva
Remove old fault tolerance tests
77af426
@emmadesilva
Add new fault tolerance tests
c3a46c9
@emmadesilva
Update test for the new dynamic Markdown link feature
b79d983
@emmadesilva
Use existing file pending mock support
c644501
@emmadesilva
Replace feature test setup with lower level filesystem configuration
6e50913
@emmadesilva
Tear down filesystem after class
6d6d753
@emmadesilva
Update test for the new dynamic Markdown link feature
48558fa
@emmadesilva
Add more high level feature test cases
60786a5
@emmadesilva emmadesilva force-pushed the improved-dynamic-markdown-links branch from 4bd6a59 to 76672b2 Compare July 25, 2024 14:20
@emmadesilva emmadesilva merged commit f4c9984 into dynamic-markdown-links Jul 25, 2024
@emmadesilva emmadesilva deleted the improved-dynamic-markdown-links branch July 25, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emmadesilva