Fix function with multiple namespaces#1061
Merged
theofidry merged 4 commits intohumbug:mainfrom Sep 2, 2024
VincentLanglet:fixMultinamespace
Merged
Fix function with multiple namespaces#1061theofidry merged 4 commits intohumbug:mainfrom VincentLanglet:fixMultinamespace
theofidry merged 4 commits intohumbug:mainfrom
VincentLanglet:fixMultinamespace
Conversation
Member
|
Thank you @VincentLanglet, I'll try to check the CI ASAP to fix it to get this merged |
Contributor
Author
Should I fix the test on this PR @theofidry ? It seems to mainly be CS issues |
Member
|
@VincentLanglet the CS yes (I think it's related), but the test failures looks unrelated so in a different MR. Sorry I'm a bit overwhelmed IRL between visists and moving and stuff |
Contributor
Author
|
VincentLanglet
commented
Sep 2, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @theofidry, I discovered a bug with the php-scoper.
Before the fix, I get
which is crashing.