Fixed scoper-autoload.php PHP 5.6 incompatibility#1024
Merged
theofidry merged 2 commits intohumbug:mainfrom May 3, 2024
marekdedic:php-5-fix
Merged
Fixed scoper-autoload.php PHP 5.6 incompatibility#1024theofidry merged 2 commits intohumbug:mainfrom marekdedic:php-5-fix
theofidry merged 2 commits intohumbug:mainfrom
marekdedic:php-5-fix
Conversation
theofidry
reviewed
Apr 30, 2024
Member
theofidry
left a comment
There was a problem hiding this comment.
I thought the Composer autoloader now requires PHP 7.2 minimum?
Contributor
Author
I don't think so - the autoload script definitely checks if it's on PHP 5.6 or older, so I suppose it should support very old PHP...? You can't run composer on such old PHP, but that's a different thing from running the generated autoloader... |
Member
|
Thank you @marekdedic, I can't promise this sticks around without any automated test for it but it doesn't hurt to have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1023