Skip to content

Add --format pretty as default#116

Merged
hugovk merged 3 commits intomainfrom
default-format-pretty
Dec 4, 2022
Merged

Add --format pretty as default#116
hugovk merged 3 commits intomainfrom
default-format-pretty

Conversation

@hugovk
Copy link
Copy Markdown
Owner

@hugovk hugovk commented Dec 3, 2022

  • Add a new --format pretty
  • Make --format pretty the default instead of --format markdown
  • Add a new --format md as a shortcut to --format markdown

Before

$ eol python
| cycle |  release   | latest | latest release |    eol     |
|:------|:----------:|:-------|:--------------:|:----------:|
| 3.11  | 2022-10-24 | 3.11.0 |   2022-10-24   | 2027-10-24 |
| 3.10  | 2021-10-04 | 3.10.8 |   2022-10-11   | 2026-10-04 |
| 3.9   | 2020-10-05 | 3.9.15 |   2022-10-11   | 2025-10-05 |
| 3.8   | 2019-10-14 | 3.8.15 |   2022-10-11   | 2024-10-14 |
| 3.7   | 2018-06-26 | 3.7.15 |   2022-10-10   | 2023-06-27 |
| 3.6   | 2016-12-22 | 3.6.15 |   2021-09-03   | 2021-12-23 |
| 3.5   | 2015-09-12 | 3.5.10 |   2020-09-05   | 2020-09-13 |
| 3.4   | 2014-03-15 | 3.4.10 |   2019-03-18   | 2019-03-18 |
| 3.3   | 2012-09-29 | 3.3.7  |   2017-09-19   | 2017-09-29 |
| 2.7   | 2010-07-03 | 2.7.18 |   2020-04-19   | 2020-01-01 |
| 2.6   | 2008-10-01 | 2.6.9  |   2013-10-29   | 2013-10-29 |

Same as:

$ eol python --format markdown
| cycle |  release   | latest | latest release |    eol     |
|:------|:----------:|:-------|:--------------:|:----------:|
| 3.11  | 2022-10-24 | 3.11.0 |   2022-10-24   | 2027-10-24 |
| 3.10  | 2021-10-04 | 3.10.8 |   2022-10-11   | 2026-10-04 |
| 3.9   | 2020-10-05 | 3.9.15 |   2022-10-11   | 2025-10-05 |
| 3.8   | 2019-10-14 | 3.8.15 |   2022-10-11   | 2024-10-14 |
| 3.7   | 2018-06-26 | 3.7.15 |   2022-10-10   | 2023-06-27 |
| 3.6   | 2016-12-22 | 3.6.15 |   2021-09-03   | 2021-12-23 |
| 3.5   | 2015-09-12 | 3.5.10 |   2020-09-05   | 2020-09-13 |
| 3.4   | 2014-03-15 | 3.4.10 |   2019-03-18   | 2019-03-18 |
| 3.3   | 2012-09-29 | 3.3.7  |   2017-09-19   | 2017-09-29 |
| 2.7   | 2010-07-03 | 2.7.18 |   2020-04-19   | 2020-01-01 |
| 2.6   | 2008-10-01 | 2.6.9  |   2013-10-29   | 2013-10-29 |

After

Now the default has joined lines, and this is the same as the new eol python --format pretty:

eol python
┌───────┬────────────┬────────┬────────────────┬────────────┐
│ cycle │  release   │ latest │ latest release │    eol     │
├───────┼────────────┼────────┼────────────────┼────────────┤
│ 3.11  │ 2022-10-24 │ 3.11.0 │   2022-10-24   │ 2027-10-24 │
│ 3.10  │ 2021-10-04 │ 3.10.8 │   2022-10-11   │ 2026-10-04 │
│ 3.9   │ 2020-10-05 │ 3.9.15 │   2022-10-11   │ 2025-10-05 │
│ 3.8   │ 2019-10-14 │ 3.8.15 │   2022-10-11   │ 2024-10-14 │
│ 3.7   │ 2018-06-26 │ 3.7.15 │   2022-10-10   │ 2023-06-27 │
│ 3.6   │ 2016-12-22 │ 3.6.15 │   2021-09-03   │ 2021-12-23 │
│ 3.5   │ 2015-09-12 │ 3.5.10 │   2020-09-05   │ 2020-09-13 │
│ 3.4   │ 2014-03-15 │ 3.4.10 │   2019-03-18   │ 2019-03-18 │
│ 3.3   │ 2012-09-29 │ 3.3.7  │   2017-09-19   │ 2017-09-29 │
│ 2.7   │ 2010-07-03 │ 2.7.18 │   2020-04-19   │ 2020-01-01 │
│ 2.6   │ 2008-10-01 │ 2.6.9  │   2013-10-29   │ 2013-10-29 │
└───────┴────────────┴────────┴────────────────┴────────────┘

Also add --format md as shortcut for --format markdown.

image

@hugovk hugovk added enhancement New feature or request changelog: Added For new features labels Dec 3, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 3, 2022 •
edited
Loading

Codecov Report

Merging #116 (7147b88) into main (8448099) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   95.34%   95.40%   +0.05%     
==========================================
  Files           9        9              
  Lines         387      392       +5     
==========================================
+ Hits          369      374       +5     
  Misses         18       18
Flag Coverage Δ
macos-latest 95.40% <100.00%> (+0.05%) ⬆️
ubuntu-latest 95.40% <100.00%> (+0.05%) ⬆️
windows-latest 95.40% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/norwegianblue/cli.py 0.00% <ø> (ø)
src/norwegianblue/__init__.py 98.59% <100.00%> (+0.04%) ⬆️
tests/data/expected_output.py 100.00% <100.00%> (ø)
tests/test_norwegianblue.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hugovk hugovk merged commit de626d9 into main Dec 4, 2022
@hugovk hugovk deleted the default-format-pretty branch December 4, 2022 18:02
This was referenced Dec 6, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

changelog: Added For new features enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hugovk